git: re-add support for git decoration preferences #11674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit re-adds support for `git.decorations.enabled` and `git.decorations.colors` which were previously not referenced and supported after a change in `v1.14.0`. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
added
git
msujew
reviewed
Sep 16, 2022
Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
|
@msujew thank you for your help, I like it better than having to cache the event itself. |
msujew
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
The changes look good to me 👍
- Decorations are applied/colored correctly when both preferences are enabled
- Decorations can be completely disabled
- Decoration colors can be disabled independently of that
- Changes these preferences is applied correctly and instantly
alvsan09
approved these changes
Sep 20, 2022
EstFoisy
pushed a commit
to EstFoisy/theia
that referenced
this pull request
Sep 20, 2022
The commit re-adds support for `git.decorations.enabled` and `git.decorations.colors` which were previously not referenced and supported after a change in `v1.14.0`. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com> Co-authored-by: Mark Sujew <mark.sujew@typefox.io>
EstFoisy
pushed a commit
to EstFoisy/theia
that referenced
this pull request
Sep 21, 2022
The commit re-adds support for `git.decorations.enabled` and `git.decorations.colors` which were previously not referenced and supported after a change in `v1.14.0`. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com> Co-authored-by: Mark Sujew <mark.sujew@typefox.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The pull-request re-adds support for
git.decorations.enabledandgit.decorations.colorswhich were previously not referenced and supported after a change in #8911 (v1.14.0).git-decorations.mov
How to test
git decorationsgit.decorations.enabledhides/shows decorations in the navigator for the resourcesgit.decorations.colorshides/displays colors for the decorations in the navigator for the resourcesReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com